Implementation Shattered Planes
- Thread starter Cpt. Crispy Crunchy
- Start date
Haha ok I will do that @Cervator! Is there any news concerning the future of https://github.com/MovingBlocks/Terasology/pull/2282 ? I think it could make sense to add along a lake biome to later have an easy time adding lake plants or something similar.
Btw I will make it pluggable @Josharias
.
Also thanks for accepting my proposal yaaaaay
Btw I will make it pluggable @Josharias
. Also thanks for accepting my proposal yaaaaay
PR - I think @Josharias is going to rework it and submit a new one soon
Proposal - congratulations! I assigned you to the GSOC issue on GitHub I think that whole thing originated with - proposal is a fair bit fancier than the issue, although there's an old forum link with some more info in, you've probably already seen it
Proposal - congratulations! I assigned you to the GSOC issue on GitHub I think that whole thing originated with - proposal is a fair bit fancier than the issue, although there's an old forum link with some more info in, you've probably already seen it
nice! I will test it tomorrow @Josharias!
Quick update: Performance was increased tremendously and has achieved perlin world gen speed! This was achieved with Josharias method of getting noise values on batch. Thanks for the tipp @Josharias
Unfortunately that means I have to access the getRelativeWorldIndex method of the SurfaceHeightFacet which is protected by default. Making a new SurfaceHeightFacet leads also to problems as the playerspawner needs that and other things of core which the module depends on.
Would it be possible to make that public? I see no further problems with that but maybe I've overlooked something.
The ShatteredPlanes patch is currently in the test branch -> https://github.com/Terasology/ShatteredPlanes/tree/test
but you would need to add
to the SurfaceHeightFacet to test it.
I'll make an Issue out of that for further discussion.
Unfortunately that means I have to access the getRelativeWorldIndex method of the SurfaceHeightFacet which is protected by default. Making a new SurfaceHeightFacet leads also to problems as the playerspawner needs that and other things of core which the module depends on.
Would it be possible to make that public? I see no further problems with that but maybe I've overlooked something.
The ShatteredPlanes patch is currently in the test branch -> https://github.com/Terasology/ShatteredPlanes/tree/test
but you would need to add
Code:
public int getWorldIndex(BaseVector2i pos) {
return getWorldIndex(pos.x(),pos.y());
}I'll make an Issue out of that for further discussion.
It seems to me a good idea to change the getRelativeIndex(...) and getWorldIndex(...) protected methods in both BaseFacet2D and BaseFacet3D to public. Making an array of noise seems to be the only path to performance, so having these methods available seems like the only way to go. I havent gone looking, but is there some sort of utility class that this would fit in? instead of baking it into the facet classes.