Weather and World Gen

[RatMoleRat]

For my TSOC project, I'm planning on expanding our WeatherManager and ClimateConditions modules. Weather will be connected to climate maps, of which several new kinds will be added. The world will also be adjusted (such as through erosion) based on weather and climate occurrences.

Weekly meetings for this project are scheduled for Sundays at 7 pm UTC. The Trello board with most specific objectives is located at https://trello.com/b/lcsyfPBm/tsoc-2020-ideas-weather-and-world-gen. I'll update this forum post with my progress and a summary of each week's meeting!

 

[RatMoleRat]

Update #1 below, based on our first meeting.

What have you achieved in the last week?
I've updated my workspace to the most recent versions of Terasology and ClimateConditions. I've also edited how the maps are generated - instead of purely being noise, they are noise based on biomes and blocks already in the world.

What are you currently working on?
I still have a couple bugs to work out with the current map generation before making a PR with it. I also am restructuring my Trello board slightly (breaking up large tasks into multiple cards). After that, I'll add more variable maps (most notably wind) to the world and start work on making the maps alter each other. The wind might blow hot/cold air around, for example.

What problems are you currently facing?
None right now.

Is anything blocking you from making progress?
Nope.

List of PRs and opened/closed Issues:
None right now; I expect to make a PR with my work so far by Tuesday.

 

[RatMoleRat]

Update #2 below, in preparation for our second meeting.

What have you achieved in the last week?
I've fixed the bugs with my map generation and formed a PR for that. I finished restructuring my Trello board. I made some progress with the WeatherManager's water cycle, but a rendering memory leak is stopping me there. I also fully restructured my Trello board, and added pollution and wind maps to the game (not yet in a PR since I need to test more fully). I recently rescaled temperature, too, which is included in my ClimateConditions PR.

What are you currently working on?
I'm currently finishing up air pressure (wind) maps and adding erosion maps. After that, my next step will be to move the maps around, or to finish the water cycle and tie WeatherManager precipitation events to the temperature/humidity maps (if I can run WeatherManager again).

What problems are you currently facing?
There's the WeatherManager issue (see below for a link to my Discord post on it). Beyond that, everything is fine.

Is anything blocking you from making progress?
The WeatherManager crash keeps me from making more progress on that module for now, so I moved back to working on ClimateConditions. Here's a link to my comment on Discord with the full error log from the crashes: https://discord.com/channels/270264625419911192/702893102481932308/721575185672831017

List of PRs and opened/closed Issues:
https://github.com/Terasology/ClimateConditions/pull/18

 

[RatMoleRat]

Update #3 below, in preparation for our third (actually second) meeting.

What have you achieved in the last week?
I've made several changes to my open PR. Prior to that, I did more work on wind maps, but restructuring my PR will break those changes, so I'm going to wait for it (#18) to be merged before proceeding with maps. I somehow - still not sure how - got WeatherManager to work again (thinking it was a workspace issue earlier?) and worked on the block placing system more. A PR for that will come out soon.

What are you currently working on?
I'm currently working on placing water blocks when it rains, melting snow blocks, and otherwise adjusting the weather cycle so that rain is tied to temperature/humidity maps (that's my immediate goal right now).

Is anything blocking you from making progress?
I'd really appreciate a PR review on #18 - I'm hesitant to proceed with adding new maps until its merged, since there generation will be dependent on the final structure there.

 

[RatMoleRat]

What have you achieved in the last week?
I finally made a PR with some more water cycle work in the WeatherManager. I also updated my ClimateConditions PR to make base temperature/humidity values on the BiomesAPI, rather than setting them in CC for only CoreBiomes

What are you currently working on?
I'm currently trying debug WeatherManager's FlowingLiquids issue (see below) so that my water cycle PR can be merged. I'm also waiting for my ClimateConditions PR to get merged so I can proceed more easily with maps, etc.

What problems are you currently facing?
There's the WeatherManager issue with FlowingLiquids (log is at https://pastebin.com/WEMi3NeP). I'm also wondering if I can add more maps (the pollution, wind, etc.) into my ClimateConditions PR right now, or if I need to wait to ensure that PR doesn't get too big.

Is anything blocking you from making progress?
See my question above.

List of PRs and opened/closed Issues:
https://github.com/Terasology/ClimateConditions/pull/18
https://github.com/Terasology/BiomesAPI/pull/5
https://github.com/Terasology/CoreWorlds/pull/8
https://github.com/Terasology/WeatherManager/pull/15

 

[RatMoleRat]

What have you achieved in the last week?
I updated my WeatherManager PR to respond to review comments and add FlowingLiquids as a dependency. I recently also pushed past changes to my open CoreWorlds PR - those changes tie the temperature and biome facets to the new temperature scale.

What are you currently working on?
I'm currently trying to resolve a couple more issues with the WeatherManager PR, and I'm also working on tying ClimateConditions to WM so that weather generates based on the climate.

What problems are you currently facing?
I'm still stuck with the CoreWorlds/BiomesAPI/CC trio of PRs. Biome facets and temperature facets are now related, but I can't figure out how to make the temperature stored there relate to the CC maps. I'm thinking this is a case of trying to not let the good (and hence progress) be the enemy of the perfect, but I still don't know what any "good" route would be.

Is anything blocking you from making progress?
See above.

List of PRs and opened/closed Issues:
https://github.com/Terasology/CoreWorlds/pull/8
https://github.com/Terasology/WeatherManager/pull/15

 

[RatMoleRat]

What have you achieved in the last week?
I resolved some more problems with my WeatherManager PR and started looking into using extra block data for my CoreWorlds/BiomesAPI/CC trio of PRs.

What are you currently working on?
I'm currently investigating the problem with WM in multiplayer that was discovered during the play test this week.

What problems are you currently facing?
I'm not sure what the problem with multiplayer WM is - I think it's something to do with the events not reaching all players, if that makes sense. A command seems to change it only for the player that ran the command.

List of PRs and opened/closed Issues:
https://github.com/Terasology/WeatherManager/pull/15

 

[RatMoleRat]

What have you achieved in the last week?
I got the WeatherManager PR merged (#15 - still looking into the multiplayer issues), and made progress with adding extra block data to the trio of PRs to CoreWorlds/ClimateConditions/BiomesAPI.

What are you currently working on?
I'm currently trying to solve a couple lingering problems with CW and CC (see below). After that, I can finally move on with adding additional maps and the later cards in my Trello.

What problems are you currently facing?
The new code I recently pushed to CW and CC partially works. It uses extra block data to save humidity and temperature from facets. However, when I move from the initial chunk, temperature and humidity data doesn't work anymore - it becomes 0 or 1 (clamped, so very high or very low values). I'm not sure what's causing this.

List of PRs and opened/closed Issues:
https://github.com/Terasology/ClimateConditions/pull/18
https://github.com/Terasology/CoreWorlds/pull/8

 

[RatMoleRat]

What have you achieved in the last week?
I made more changes to the block data, trying to debug the error linked below. Also working on the TSOC post for agent-q1.

What are you currently working on?
Debugging the below. I'm not sure why it's happening, since I don't think I've touched that area recently:
https://pastebin.pl/view/ac00294a

What problems are you currently facing?
See above.

 

[RatMoleRat]

What have you achieved in the last week?
I finished up the two PRs linked below, which should be ready for review and merge.

What are you currently working on?
I'm moving back to modifying the weather process in WeatherManager, now that the other two PRs will make the climate values correspond better to the world.

What problems are you currently facing?
None at the moment.

List of PRs and opened/closed Issues:
https://github.com/Terasology/ClimateConditions/pull/18
https://github.com/Terasology/CoreWorlds/pull/8
Both ready for review!